Summary: | WebPDFView should remove itself as the delegate of its PDFView before being dealloced | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Thole <mthole> | ||||
Component: | Assignee: | Mike Thole <mthole> | |||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Mike Thole
2010-08-23 11:03:52 PDT
Created attachment 65141 [details]
Proposed patch
Comment on attachment 65141 [details] Proposed patch > Index: WebKit/mac/ChangeLog > =================================================================== > --- WebKit/mac/ChangeLog (revision 65818) > +++ WebKit/mac/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-08-23 Mike Thole <mthole@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WebKit should nil out PDFView's delegate before releasing it The change is good, but the description isn’t totally accurate. The problem is that the WebPDFView is deallocated while it is still the delegate, not that the PDFView is being released while having a non-nil delegate. Good point Dan. I've updated the title to more accurately reflect the actual problem: "WebPDFView should remove itself as the delegate of its PDFView before being dealloced" Committed revision 65820. |