Bug 44429

Summary: Table Rendering Layout Test Expectations Updated
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
dglazkov: review-, dglazkov: commit-queue-
Patch dglazkov: review+, commit-queue: commit-queue-

Fady Samuel
Reported 2010-08-23 08:47:49 PDT
Table Rendering Layout Test Expectations Updated
Attachments
Patch (2.54 KB, patch)
2010-08-23 08:52 PDT, Fady Samuel 		dglazkov: review-
dglazkov: commit-queue-
DetailsFormatted DiffDiff
Patch (11.64 KB, patch)
2010-08-23 09:09 PDT, Fady Samuel 		dglazkov: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2010-08-23 08:52:39 PDT
Created attachment 65124 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-08-23 08:57:40 PDT
Comment on attachment 65124 [details] Patch ok.
Dimitri Glazkov (Google)
Comment 3 2010-08-23 09:02:43 PDT
Comment on attachment 65124 [details] Patch whoops, the diff doesn't reflect moving files.
Fady Samuel
Comment 4 2010-08-23 09:09:09 PDT
Created attachment 65128 [details] Patch
Dimitri Glazkov (Google)
Comment 5 2010-08-23 12:22:20 PDT
Comment on attachment 65128 [details] Patch ok.
WebKit Commit Bot
Comment 6 2010-08-23 16:54:39 PDT
Comment on attachment 65128 [details] Patch Rejecting patch 65128 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--force']" exit_code: 255 Parsed 8 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/table/simple_paint-expected.checksum literal is only avaliable with the XS version at /Library/Perl/5.8.8/Compress/Zlib.pm line 9 BEGIN failed--compilation aborted at /Library/Perl/5.8.8/Compress/Zlib.pm line 9. Compilation failed in require at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/VCSUtils.pm line 1670. Full output: http://queues.webkit.org/results/3796289
Dimitri Glazkov (Google)
Comment 7 2010-08-25 12:54:50 PDT
Committed r66034: <http://trac.webkit.org/changeset/66034>
Note You need to log in before you can comment on or make changes to this bug.