Summary: | [Qt] TransparencyLayer: Always use anti-aliasing and smooth pixmap transform | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ariya.hidayat | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://dev.sencha.com/deploy/touch/examples/kitchensink/ | ||||||||
Attachments: |
|
Description
Andreas Kling
2010-08-22 02:53:48 PDT
Created attachment 65052 [details]
Proposed patch
Created attachment 65054 [details]
Comparison (bottom version is with patch)
Comment on attachment 65052 [details]
Proposed patch
WebCore/platform/graphics/qt/TransparencyLayer.h:55
+ painter.setRenderHints(QPainter::Antialiasing | QPainter::SmoothPixmapTransform);
Can't we copy the hints from p? Or does p have the wrong hints?
(In reply to comment #3) > (From update of attachment 65052 [details]) > WebCore/platform/graphics/qt/TransparencyLayer.h:55 > + painter.setRenderHints(QPainter::Antialiasing | QPainter::SmoothPixmapTransform); > Can't we copy the hints from p? Or does p have the wrong hints? It has the wrong hints in this case. Regardless, when do we want to paint with a low quality mask? > It has the wrong hints in this case. Regardless, when do we want to paint with a low quality mask?
We don't, but it's up to the developer. One may want to call QWebFrame::render with low-quality because she is animating, capturing thumbnail only, or doing other funky stuff for which she care more about speed as opposed to pixel perfectness.
Comment on attachment 65052 [details]
Proposed patch
r+ for this fix, as it works for now.
I guess I need to resume my render hints propagation investigation...
Comment on attachment 65052 [details] Proposed patch Clearing flags on attachment: 65052 Committed r65784: <http://trac.webkit.org/changeset/65784> All reviewed patches have been landed. Closing bug. |