Summary: | [Qt] Gradient: Support inner radius larger than outer radius | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | HTML5, Qt, QtTriaged | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andreas Kling
2010-08-21 22:09:08 PDT
Created attachment 65047 [details]
Proposed patch
Created attachment 65049 [details]
Proposed patch v2
Updated patch addressing comments from Ariya on IRC.
Comment on attachment 65049 [details]
Proposed patch v2
LGTM.re=me.
Minor issue:
WebCore/platform/graphics/qt/GradientQt.cpp:76
+ if (m_radial && !qFuzzyCompare(outerRadius, qreal(0))) {
Should be qFuzzyCompare(1 + outerRadius, qreal(1)).
Committed r65783: <http://trac.webkit.org/changeset/65783> |