| Summary: | TreeWalker traversal order is wrong when skipping and rejecting | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | DOM | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, eric, kling, sam, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| URL: | http://www-archive.mozilla.org/docs/dom/samples/treewalkerdemo.xml | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2010-08-20 21:07:27 PDT
I have some tests that work fine, but when I load http://www-archive.mozilla.org/docs/dom/samples/treewalkerdemo.xml and hit the "All datatypes" button, the result is different from Firefox. Created attachment 65020 [details] Add some tests (that all pass when bug 35296 is fixed) I was able to reduce a problem not covered by these tests. Will attach later. Created attachment 65031 [details]
Patch
Created attachment 65034 [details]
Patch
Comment on attachment 65034 [details]
Patch
Oops, attached the same patch again.
Comment on attachment 65031 [details]
Patch
LGTM (not a reviewer though.)
Of note: This change will make WebKit pass 2 additional tests on the IE Test Center (previous- and nextSibling() with NodeFilter)
http://trac.webkit.org/changeset/65914 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65913 http://trac.webkit.org/changeset/65914 http://trac.webkit.org/changeset/65915 Comment on attachment 65020 [details] Add some tests (that all pass when bug 35296 is fixed) http://trac.webkit.org/changeset/65914 |