Bug 44373

Summary: WebKit does not build with Python 2.3
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Replace the call to sorted() by List::sort() none

Description Benjamin Poulain 2010-08-20 19:45:35 PDT
The patch of https://bugs.webkit.org/show_bug.cgi?id=43949 introduce a python script in the build system to create html entities.

This script requires Python 2.4 because of the function sorted(). This is quite annoying since Scratchbox (for Maemo for example) and older Macs have Python 2.3.
Comment 1 Benjamin Poulain 2010-08-20 19:50:57 PDT
Created attachment 65017 [details]
Replace the call to sorted() by List::sort()

This simple change makes it possible to compile for Maemo 5 again.
Comment 2 WebKit Commit Bot 2010-08-20 20:35:14 PDT
Comment on attachment 65017 [details]
Replace the call to sorted() by List::sort()

Rejecting patch 65017 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20893 test cases.
animations/suspend-resume-animation.html -> failed

Exiting early after 1 failures. 127 tests run.
32.78s total testing time

126 test cases (99%) succeeded
1 test case (<1%) had incorrect layout

Full output: http://queues.webkit.org/results/3723404
Comment 3 Andreas Kling 2010-08-20 20:39:19 PDT
Comment on attachment 65017 [details]
Replace the call to sorted() by List::sort()

Clearing flags on attachment: 65017

Committed r65773: <http://trac.webkit.org/changeset/65773>
Comment 4 Andreas Kling 2010-08-20 20:39:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Seidel (no email) 2010-08-21 07:38:05 PDT
Thanks.  It's kinda sad, since we require python 2.5 to run the tests.  However we made a special exception for Apple's Tiger bot to support 2.3 for building.

What platform do you have which still uses Python 2.3?  It's ancient!

(Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on.  I just happened to see this since I get the commit-bot email, but Adam wrote this code.)

Thanks for the fix. :)
Comment 6 Adam Barth 2010-08-21 10:11:14 PDT
Without a way to test this on the buildbot, we're going to keep regressing this whenever we touch this script.
Comment 7 Benjamin Poulain 2010-08-21 10:23:15 PDT
(In reply to comment #5)
> What platform do you have which still uses Python 2.3?  It's ancient!

Yep.
Maemo itself uses Python 2.5+, but the build system still uses Python 2.3.
We also support Mac OS X Tiger in the Tier 2 platforms of Qt 4.6.

> (Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on.  I just happened to see this since I get the commit-bot email, but Adam wrote this code.)

Sorry. I thought that was not necessary given how trivial the fix is.