Bug 4437

Summary: clean up error creation with new throwError function
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: VERIFIED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
adds new throwError function, uses it in every suitable place, other cleanup
none
adds new throwError function, uses it, other cleanup (merged with TOT) ggaren: review+

Darin Adler
Reported 2005-08-14 22:50:00 PDT
There are a lot of calls to Error::create followed by calls to exec->setException. I'd like to simplify that idiom with a new throwError function.
Attachments
adds new throwError function, uses it in every suitable place, other cleanup (141.06 KB, patch)
2005-08-14 22:50 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
adds new throwError function, uses it, other cleanup (merged with TOT) (148.54 KB, patch)
2005-08-14 22:53 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-08-14 22:50:52 PDT
Created attachment 3393 [details] adds new throwError function, uses it in every suitable place, other cleanup
Darin Adler
Comment 2 2005-08-14 22:53:42 PDT
Created attachment 3394 [details] adds new throwError function, uses it, other cleanup (merged with TOT)
Geoffrey Garen
Comment 3 2005-08-15 15:21:51 PDT
Comment on attachment 3394 [details] adds new throwError function, uses it, other cleanup (merged with TOT) r=me.
Note You need to log in before you can comment on or make changes to this bug.