Bug 44347

Summary:

[Qt] constify core() and kit() parameters

Product:

WebKit

Reporter:

Ademar Reis <ademar>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
constify core() and kit() parameters from the private classes	none

Ademar Reis

Reported 2010-08-20 12:38:19 PDT

The parameters to the private methods core() and kit() should be constified. Essencial if we need to call "core(this)" from inside a const method (a getter, for example). Patch is on the way

Attachments
constify core() and kit() parameters from the private classes (4.33 KB, patch) 2010-08-20 12:47 PDT, Ademar Reis	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ademar Reis

Comment 1 2010-08-20 12:47:43 PDT

Created attachment 64974 [details] constify core() and kit() parameters from the private classes

Ariya Hidayat

Comment 2 2010-08-20 16:24:11 PDT

Comment on attachment 64974 [details] constify core() and kit() parameters from the private classes LGTM, re=me

WebKit Commit Bot

Comment 3 2010-08-20 18:02:30 PDT

Comment on attachment 64974 [details] constify core() and kit() parameters from the private classes Clearing flags on attachment: 64974 Committed r65771: <http://trac.webkit.org/changeset/65771>

WebKit Commit Bot

Comment 4 2010-08-20 18:02:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.