Bug 44347

Summary: [Qt] constify core() and kit() parameters
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
constify core() and kit() parameters from the private classes none

Description Ademar Reis 2010-08-20 12:38:19 PDT 
The parameters to the private methods core() and kit() should be constified.

Essencial if we need to call "core(this)" from inside a const method (a getter, for example).

Patch is on the way
Comment 1 Ademar Reis 2010-08-20 12:47:43 PDT 
Created attachment 64974 [details]
constify core() and kit() parameters from the private classes
Comment 2 Ariya Hidayat 2010-08-20 16:24:11 PDT 
Comment on attachment 64974 [details]
constify core() and kit() parameters from the private classes

LGTM, re=me
Comment 3 WebKit Commit Bot 2010-08-20 18:02:30 PDT 
Comment on attachment 64974 [details]
constify core() and kit() parameters from the private classes

Clearing flags on attachment: 64974

Committed r65771: <http://trac.webkit.org/changeset/65771>
Comment 4 WebKit Commit Bot 2010-08-20 18:02:36 PDT 
All reviewed patches have been landed.  Closing bug.