Bug 44342

Summary: [GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: caseq, joepeck, loislo, pfeldman
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix dependency tracking for inspector copied files joepeck: review+

Description Martin Robinson 2010-08-20 10:05:47 PDT
For tests:
inspector/extensions-api.html
inspector/extensions.html

The bots show diffs like this:

     panels : {
         elements : {
             createSidebarPane : <function>
-            onSelectionChanged : {
-                addListener : <function>
-                removeListener : <function>
-            }
         }
         scripts : {
             createSidebarPane : <function>
-            onSelectionChanged : {
-                addListener : <function>
-                removeListener : <function>
-            }
         }
         create : <function>
     }
Comment 1 Martin Robinson 2010-08-20 10:14:20 PDT
Committed r65739: <http://trac.webkit.org/changeset/65739>
Comment 2 Martin Robinson 2010-08-20 14:46:21 PDT
In this case, it appears that WebKitGTK+ is loading a stale copy of the inspector files for the tests. I should have a patch up shortly. Sorry for the noise!
Comment 3 Martin Robinson 2010-08-20 16:38:29 PDT
Created attachment 65008 [details]
Fix dependency tracking for inspector copied files
Comment 4 Joseph Pecoraro 2010-08-20 16:44:22 PDT
Comment on attachment 65008 [details]
Fix dependency tracking for inspector copied files

> diff --git WebCore/GNUmakefile.am
>  # RemoteInspectorFrontend and InspectorBackendDispatcher
> -DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm
> +DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h DerivedSources/WebCore/InspectorBackendStub.js: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm

The comment above this should be updated as well. Maybe just
something like: "All Web Inspector Generated Files"


> +${GENSOURCES_INSPECTOR}/inspector.html: $(WebCore)/inspector/front-end/*.html \
> +		$(WebCore)/inspector/front-end/*.js $(WebCore)/inspector/front-end/*.css \
> ...
>  	mkdir -p ${GENSOURCES_INSPECTOR}/images
>  	cp ${dist_webinspector_DATA} ${GENSOURCES_INSPECTOR}
>  	cp ${dist_webinspectorimages_DATA} ${GENSOURCES_INSPECTOR}/images


Separate these two lines, it makes it easier to read.
And can you instead change the variable (dist_webinspector_DATA)
to include the full paths? I'm surprised the `cp` later on
works if that didn't have the proper paths.
Comment 5 Joseph Pecoraro 2010-08-20 16:45:54 PDT
> > +		$(WebCore)/inspector/front-end/*.js $(WebCore)/inspector/front-end/*.css \

These are what I wanted separated into two lines.
Comment 6 Joseph Pecoraro 2010-08-20 17:03:03 PDT
Comment on attachment 65008 [details]
Fix dependency tracking for inspector copied files

Although I don't like the duplicated lines, I know you tried
a few different approaches. r=me addressing the comments above.
Comment 7 Martin Robinson 2010-08-20 17:13:23 PDT
Committed r65767: <http://trac.webkit.org/changeset/65767>