Bug 44319 – [EFL] Add setting API for enabling local storage.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Gyuyoung Kim]

Add APIs to enable / disable local storage.

[Gyuyoung Kim]

Created attachment 64924 [details]
Patch

[Lucas De Marchi]

Comment on attachment 64924 [details]
Patch

> diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog
> index de65885..d921cae 100644
> --- a/WebKit/efl/ChangeLog
> +++ b/WebKit/efl/ChangeLog
> @@ -1,3 +1,18 @@
> [phone]  Gyuyoung Kim  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [EFL] Add setting API for enabling local storage.
> +        https://bugs.webkit.org/show_bug.cgi?id=44319
> +
> +        Add API for enabling/disabling local storage.
> +
> +        * ewk/ewk_view.cpp:
> +        (_ewk_view_priv_new):
> +        (ewk_view_setting_local_storage_get): Added
> +        (ewk_view_setting_local_storage_set): Added
> +        * ewk/ewk_view.h:
> +
>  2010-08-15  Gyuyoung Kim  <[e-mail]>
>  
>          Reviewed by Antonio Gomes.
> diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp
> index 7a98bac..40794eb 100644
> --- a/WebKit/efl/ewk/ewk_view.cpp
> +++ b/WebKit/efl/ewk/ewk_view.cpp
> @@ -107,6 +107,7 @@ struct _Ewk_View_Private_Data {
>          Eina_Bool private_browsing:1;
>          Eina_Bool caret_browsing:1;
>          Eina_Bool spatial_navigation:1;
> +        Eina_Bool local_storage:1;
>          struct {
>              float w;
>              float h;
> @@ -593,6 +594,7 @@ static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd)
>      priv->settings.resizable_textareas = priv->page_settings->textAreasAreResizable();
>      priv->settings.private_browsing = priv->page_settings->privateBrowsingEnabled();
>      priv->settings.caret_browsing = priv->page_settings->caretBrowsingEnabled();
> +    priv->settings.local_storage = priv->page_settings->localStorageEnabled();
>  
>      // Since there's no scale separated from zooming in webkit-efl, this functionality of
>      // viewport meta tag is implemented using zoom. When scale zoom is supported by webkit-efl,
> @@ -2627,6 +2629,25 @@ Eina_Bool ewk_view_setting_spatial_navigation_set(Evas_Object* o, Eina_Bool enab
>      return EINA_TRUE;
>  }
>  
> +Eina_Bool ewk_view_setting_local_storage_get(Evas_Object* o)

Missing doxygen here.

> +{
> +    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
> +    return priv->settings.local_storage;
> +}
> +

Missing doxygen here too.

> +Eina_Bool ewk_view_setting_local_storage_set(Evas_Object* o, Eina_Bool enable)
> +{
> +    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
> +    enable = !!enable;
> +    if (priv->settings.spatial_navigation != enable) {

local_storage not spatial_navigation




About the doxygen, yes, we don't have that on all exported functions, but let's try to keep it to a minimum.

[Antonio Gomes]

Comment on attachment 64924 [details]
Patch

It needs another round.

[Gyuyoung Kim]

Created attachment 65199 [details]
Patch

Oops, there was very stupid mistake. Thanks.

I fix it and add doxyzen. Please review again.

[Lucas De Marchi]

(In reply to comment #4)
> Created an attachment (id=65199) [details]
> Patch
> 
> Oops, there was very stupid mistake. Thanks.
> 
> I fix it and add doxyzen. Please review again.

OK, it looks good now.

[WebKit Commit Bot]

Comment on attachment 65199 [details]
Patch

Clearing flags on attachment: 65199

Committed r66080: <http://trac.webkit.org/changeset/66080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.