Bug 44318

Summary: style correction in markup.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Blocker CC: abarth, darin, eric, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 44288    
Attachments:
Description Flags
cleanup
none
fixed mac build abarth: review+

Description Ryosuke Niwa 2010-08-19 18:58:27 PDT 
style correction suggested by abarth.
Comment 1 Ryosuke Niwa 2010-08-19 19:00:51 PDT 
Created attachment 64922 [details]
cleanup
Comment 2 Ryosuke Niwa 2010-08-19 19:02:10 PDT 
(In reply to comment #1)
> Created an attachment (id=64922) [details]
> cleanup

svn diff did a terrible job here because of } but hopefully what I'm doing in appendStartMarkup is just outdenting the entire switch and renaming variables el, attr, and attrs.
Comment 3 Ryosuke Niwa 2010-08-19 19:02:43 PDT 
> svn diff did a terrible job here because of } but hopefully what I'm doing in appendStartMarkup is just outdenting the entire switch and renaming variables el, attr, and attrs.

hopefully *clear that*
Comment 4 Adam Barth 2010-08-19 19:11:27 PDT 
Comment on attachment 64922 [details]
cleanup

Thanks Ryosuke.  These diffs can be hard to read sometimes, but what I could verify looks correct and for the rest, I trust you.
Comment 5 Eric Seidel (no email) 2010-08-19 19:12:41 PDT 
Attachment 64922 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3764378
Comment 6 Ryosuke Niwa 2010-08-20 12:17:06 PDT 
Created attachment 64970 [details]
fixed mac build
Comment 7 Adam Barth 2010-08-20 12:36:30 PDT 
Comment on attachment 64970 [details]
fixed mac build

Yay.  This one builds.  :)
Comment 8 Ryosuke Niwa 2010-08-20 12:45:03 PDT 
Committed r65749: <http://trac.webkit.org/changeset/65749>