Bug 4431

Summary:

KCanvas opacity improvements

Product:

WebKit

Reporter:

Tobias Lidskog <tobiaslidskog>

Component:

SVG

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
make opacity a float	eric: review+
forgot a few changes	eric: review+
update tests	eric: review+

Tobias Lidskog

Reported 2005-08-14 15:30:59 PDT

Opacity is represented as a number between 0 and 1 everywhere i SVG, kvsg2 and kcanvas, except in KRenderingStyle and KCanvasRenderingStyle where it's 0 - 255. The inconsistency in the API is confusing, and also results in lots of extra floating point divisions (opacity = opacity/255.0) that are bad for performance.

Attachments
make opacity a float (5.95 KB, patch) 2005-08-14 15:32 PDT, Tobias Lidskog	eric: review+	Details Formatted Diff Diff
forgot a few changes (8.77 KB, patch) 2005-08-15 11:45 PDT, Tobias Lidskog	eric: review+	Details Formatted Diff Diff
update tests (10.87 KB, patch) 2005-08-15 15:03 PDT, Tobias Lidskog	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tobias Lidskog

Comment 1 2005-08-14 15:32:36 PDT

Created attachment 3385 [details] make opacity a float Changes to make opacity handling consistent in all of ksvg and kcanvas

Eric Seidel (no email)

Comment 2 2005-08-15 03:23:25 PDT

Comment on attachment 3385 [details] make opacity a float Looks fine to me.

Tobias Lidskog

Comment 3 2005-08-15 11:45:36 PDT

Created attachment 3408 [details] forgot a few changes the original file lacked a few diffs, this should be complete

Eric Seidel (no email)

Comment 4 2005-08-15 13:09:19 PDT

Comment on attachment 3408 [details] forgot a few changes Assuming this is all of them, and svg still passes all the layout tets, yes this looks fine.

Tobias Lidskog

Comment 5 2005-08-15 15:03:02 PDT

Created attachment 3412 [details] update tests truly sorry, forgot to attach the tests results that change opacity 127 -> 0.5 and 255 -> 1.0

Eric Seidel (no email)

Comment 6 2005-08-15 23:36:44 PDT

Comment on attachment 3412 [details] update tests looks good.

Note You need to log in before you can comment on or make changes to this bug.