Bug 44271

Summary:

WebKit2 should load plugins specified in the MozillaPlugins registry key (like old WebKit does)

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, andersca, eric, jhoneycutt, webkit.review.bot

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Load plugins that are specified in the MozillaPlugins registry key	sfalken: review+

Description Adam Roben (:aroben) 2010-08-19 09:24:36 PDT

Old WebKit (WebCore, really) knows how to load plugins specified in the MozillaPlugins registry key. WebKit2 should do that, too!

Comment 1 Adam Roben (:aroben) 2010-08-19 09:25:56 PDT

<rdar://problem/8329750>

Comment 2 WebKit Review Bot 2010-08-19 16:44:14 PDT

http://trac.webkit.org/changeset/65704 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/65699
http://trac.webkit.org/changeset/65700
http://trac.webkit.org/changeset/65701
http://trac.webkit.org/changeset/65702
http://trac.webkit.org/changeset/65703
http://trac.webkit.org/changeset/65704
http://trac.webkit.org/changeset/65705
http://trac.webkit.org/changeset/65706
http://trac.webkit.org/changeset/65707
http://trac.webkit.org/changeset/65708
http://trac.webkit.org/changeset/65709
http://trac.webkit.org/changeset/65710
http://trac.webkit.org/changeset/65711
http://trac.webkit.org/changeset/65712
http://trac.webkit.org/changeset/65713

Comment 3 Adam Roben (:aroben) 2010-10-14 11:16:55 PDT

Created attachment 70754 [details]
Load plugins that are specified in the MozillaPlugins registry key

Comment 4 Steve Falkenburg 2010-10-14 11:35:40 PDT

Comment on attachment 70754 [details]
Load plugins that are specified in the MozillaPlugins registry key

We should confirm that REG_EXPAND_SZ types either don't need to be handled, or are handled properly by this.

Comment 5 Adam Roben (:aroben) 2010-10-14 12:10:56 PDT

(In reply to comment #4)
> (From update of attachment 70754 [details])
> We should confirm that REG_EXPAND_SZ types either don't need to be handled, or are handled properly by this.

Firefox doesn't expand the strings, so presumably we don't need to, either. It probably wouldn't be harmful to do so, however.

Comment 6 Adam Roben (:aroben) 2010-10-14 12:31:28 PDT

Committed r69789: <http://trac.webkit.org/changeset/69789>