Bug 44268

Summary:

build-webkittestrunner doesn't build TestNetscapePlugIn on Windows

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

New Bugs

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch	sam: review+

Description Adam Roben (:aroben) 2010-08-19 08:57:23 PDT

build-webkittestrunner doesn't build TestNetscapePlugIn on Windows

Comment 1 Adam Roben (:aroben) 2010-08-19 08:58:13 PDT

Created attachment 64859 [details]
Patch

Comment 2 Sam Weinig 2010-08-19 09:24:32 PDT

Comment on attachment 64859 [details]
Patch

It also doesn't do it on the Mac. I think we should eventually move TestNetscapePlugin, ImageDiff and DumpRenderTreeSupport into their own projects, but if we wanted to fix this on the mac, we could just have build-webkittestrunner script build those targets in the DumpRenderTree project.

r=me.

Comment 3 Adam Roben (:aroben) 2010-08-19 11:05:50 PDT

<rdar://problem/8330388>

Comment 4 Adam Roben (:aroben) 2010-08-19 14:26:16 PDT

Committed r65701: <http://trac.webkit.org/changeset/65701>

Comment 5 WebKit Review Bot 2010-08-19 16:43:50 PDT

http://trac.webkit.org/changeset/65701 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/65699
http://trac.webkit.org/changeset/65700
http://trac.webkit.org/changeset/65701
http://trac.webkit.org/changeset/65702
http://trac.webkit.org/changeset/65703
http://trac.webkit.org/changeset/65704
http://trac.webkit.org/changeset/65705
http://trac.webkit.org/changeset/65706
http://trac.webkit.org/changeset/65707
http://trac.webkit.org/changeset/65708
http://trac.webkit.org/changeset/65709
http://trac.webkit.org/changeset/65710
http://trac.webkit.org/changeset/65711
http://trac.webkit.org/changeset/65712
http://trac.webkit.org/changeset/65713