Summary: | [EFL] Extend EFL WebView API to allow enable/disable Frame Flattening | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lukasz Slachciak <l.slachciak> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Enhancement | CC: | antognolli+webkit, commit-queue, gyuyoung.kim, l.slachciak, lucas.de.marchi, tonikitoo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 54809 | ||||||||||
Attachments: |
|
Description
Lukasz Slachciak
2010-08-19 05:22:03 PDT
Created attachment 64834 [details]
Implmented API for frame flattening
Hello Lukasz, Could you please add "[EFL]" prefix to the title of this bug ? And, please request review and cq for this patch. set r? and cq? flags to your patches(?) Comment on attachment 64834 [details] Implmented API for frame flattening > +/** > + * Get status of frame flattening. > + * > + * @param o view to check status > + * > + * @return EINA_TRUE if flattening is enabled, EINA_FALSE > + * otherwise (errors, flattening disabled. > + */ You missed close parentheses ")" Please re-upload your patch with the above fixed, and fill "Reviewed by" with "Antonio Gomes". Also, just set cq?. No need to re-review this. Fixed missing parenthesis. Also added Antonio as reviewer and bug url into Changelog Created attachment 65078 [details]
Implmented API for frame flattening
Comment on attachment 65078 [details] Implmented API for frame flattening Rejecting patch 65078 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20894 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14256 tests run. 250.31s total testing time 14255 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3764536 Hello Lukasz, I don't know why this patch failed to build on other ports since it's only affecting the EFL port. Anyway, unrelated to this, I was just seeing that you forgot to add the frame flattening option to the settings struct (priv->settings). Could you please update your patch with this? Thank you, Rafael Comment on attachment 64834 [details] Implmented API for frame flattening Cleared Antonio Gomes's review+ from obsolete attachment 64834 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 65226 [details]
Implmented API for frame flattening
Hello Rafael, Antonio.
I added new frame flattening option as suggested. Also adjusted the naming convention as in case of other boolean type options.
Method ewk_view_setting_enable_frame_flattening_set also updated (similar to ewk_view_setting_enable_plugins_set).
lgtm Yes, thank you for updating that. The patch looks nice now. Remember to set cq? on it too. Committed r65907: <http://trac.webkit.org/changeset/65907> In #54809 EWebLauncher was extended to use this frame flattening API |