Bug 44231

Summary: Make media/video-loop.html less timing sensitive
Product: WebKit Reporter: Andrew Scherkus <scherkus>
Component: New BugsAssignee: Andrew Scherkus <scherkus>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: eric.carlson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Andrew Scherkus
Reported 2010-08-18 23:01:16 PDT
Make media/video-loop.html less timing sensitive
Attachments
Patch (2.69 KB, patch)
2010-08-18 23:01 PDT, Andrew Scherkus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Scherkus
Comment 1 2010-08-18 23:01:37 PDT
Created attachment 64811 [details] Patch
Andrew Scherkus
Comment 2 2010-08-18 23:05:21 PDT
Hey Eric, I noticed you attempted to rewrite video-loop.html as its been flaky on GTK bots. It's also been pretty flaky on Chromium due to timeouts/floating point. I took a quick stab at trying to use seeked events as a clue to set a timeout -- I haven't begun testing on other ports to see if it improves the situation but just sending it out for initial thoughts on the subject.
Philippe Normand
Comment 3 2010-08-19 01:28:16 PDT
See also bug 33671
Eric Carlson
Comment 4 2010-08-19 09:10:37 PDT
(In reply to comment #3) > See also bug 33671 Oh my, I really dropped the ball on that one :-( I have updated the patch to hopefully be even less sensitive to timing on slow machines and marked it for review again.
Andrew Scherkus
Comment 5 2010-08-19 09:44:08 PDT
oh wow I should have searched for existing bugs as well let's go with bug 33671 as it passes consistently on chromium as well (and doesn't require platform-specific results! woohoo!!!) *** This bug has been marked as a duplicate of bug 33761 ***
chris fleizach
Comment 6 2010-09-22 00:32:02 PDT
Comment on attachment 64811 [details] Patch since this is a duplicate it looks like review should not happen on this
Note You need to log in before you can comment on or make changes to this bug.