| Summary: | Add ability to get all the keys from a WKDictionaryRef | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aroben | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2010-08-18 17:07:06 PDT
Created attachment 64790 [details]
Patch
Comment on attachment 64790 [details] Patch > +PassRefPtr<ImmutableArray> ImmutableDictionary::keys() Can this be a const member function? > + size_t size = m_map.size(); > + if (!size) I thought we used isEmpty() for things like this. > + APIObject** array = new APIObject*[size]; I think using OwnArrayPtr would be better. Or, if not, why not make the type APIObject*[]? > + return ImmutableArray::adopt(array, size); And this should take a PassOwnPtr! r=me |