Bug 44221

Summary: Add ability to get all the keys from a WKDictionaryRef
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Sam Weinig
Reported 2010-08-18 17:07:06 PDT
Add ability to get all the keys from a WKDictionaryRef
Attachments
Patch (3.72 KB, patch)
2010-08-18 17:07 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-08-18 17:07:53 PDT
Created attachment 64790 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-08-18 21:41:19 PDT
Comment on attachment 64790 [details] Patch > +PassRefPtr<ImmutableArray> ImmutableDictionary::keys() Can this be a const member function? > + size_t size = m_map.size(); > + if (!size) I thought we used isEmpty() for things like this. > + APIObject** array = new APIObject*[size]; I think using OwnArrayPtr would be better. Or, if not, why not make the type APIObject*[]? > + return ImmutableArray::adopt(array, size); And this should take a PassOwnPtr! r=me
Sam Weinig
Comment 3 2010-08-19 08:48:24 PDT
Landed in r65675.
Note You need to log in before you can comment on or make changes to this bug.