Summary: | WebView::paint fails to paint a child WebView of a Layered Window | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebKit Misc. | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, jberlin, jhoneycutt | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Jessie Berlin
2010-08-18 09:03:41 PDT
Created attachment 64724 [details]
Check if m_backingStoreBitmap is null instead of whether rcPaint is empty
Comment on attachment 64724 [details] Check if m_backingStoreBitmap is null instead of whether rcPaint is empty > + bool backingStoreCompletelyDirty = ensureBackingStore(); > + if (!m_backingStoreBitmap) { > + EndPaint(m_viewWindow, &ps); > return; > } We should only call EndPaint if a dc was passed to this function. Otherwise we won't have called BeginPaint. r=me (In reply to comment #2) > (From update of attachment 64724 [details]) > > + bool backingStoreCompletelyDirty = ensureBackingStore(); > > + if (!m_backingStoreBitmap) { > > + EndPaint(m_viewWindow, &ps); > > return; > > } > > We should only call EndPaint if a dc was passed to this function. Otherwise we won't have called BeginPaint. Added in the check for whether there was a dc passed in. > > r=me Thanks! Comment on attachment 64724 [details] Check if m_backingStoreBitmap is null instead of whether rcPaint is empty Committed in r65618 http://trac.webkit.org/changeset/65618 |