Bug 44150

Summary: NOT_REACHED is reachable in SVGLength
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, ojan, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42959    
Attachments:
Description Flags
Patch none

Description Adam Barth 2010-08-17 22:19:08 PDT
NOT_REACHED is reachable in SVGLength
Comment 1 Adam Barth 2010-08-17 22:20:00 PDT
Created attachment 64669 [details]
Patch
Comment 2 WebKit Commit Bot 2010-08-17 23:28:01 PDT
Comment on attachment 64669 [details]
Patch

Rejecting patch 64669 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20866 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 14249 tests run.
250.21s total testing time

14248 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3710359
Comment 3 WebKit Commit Bot 2010-08-18 04:33:58 PDT
Comment on attachment 64669 [details]
Patch

Rejecting patch 64669 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20868 test cases.
media/video-loop.html -> failed

Exiting early after 1 failures. 17221 tests run.
386.31s total testing time

17220 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
39 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3740341
Comment 4 Adam Barth 2010-08-18 10:52:44 PDT
Comment on attachment 64669 [details]
Patch

Why is the cq being so flaky?
Comment 5 Adam Barth 2010-08-18 10:53:06 PDT
@eric: The commit-queue is failing me.
Comment 6 Eric Seidel (no email) 2010-08-18 10:55:02 PDT
Because it got moved to a Leopard box which must have a bad CoreVideo.  At least it was a CoreVideo problem last time we saw these.

i'll move it back to a SnowLeopard box next week I guess.  Or we could hack webkit-patch to disable all media tests for the commit-queue (like we already disable all compositing tests).

The loader failure was just some random flaky test which no one has filed or fixed, I think. :)
Comment 7 WebKit Commit Bot 2010-08-18 14:00:14 PDT
Comment on attachment 64669 [details]
Patch

Rejecting patch 64669 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20875 test cases.
perf/typing-at-end-of-line.html -> failed

Exiting early after 1 failures. 17275 tests run.
536.81s total testing time

17274 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
43 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3770392
Comment 8 Eric Seidel (no email) 2010-08-18 14:06:39 PDT
Comment on attachment 64669 [details]
Patch

Sigh.  There are just lots of flaky tests in the tree right now.  Flaky tests kill the commit-queue.

I believe Ojan disabled these tests.
Comment 9 WebKit Commit Bot 2010-08-18 14:46:20 PDT
Comment on attachment 64669 [details]
Patch

Clearing flags on attachment: 64669

Committed r65632: <http://trac.webkit.org/changeset/65632>
Comment 10 WebKit Commit Bot 2010-08-18 14:46:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Nikolas Zimmermann 2010-08-18 23:56:39 PDT
Heh funky ChangeLog. Yeah I was confused ;-)