Bug 44124

Summary:

[Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies

Product:

WebKit

Reporter:

Laszlo Gombos <laszlo.gombos>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hausmann

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

S60 3rd edition

Attachments:

Description	Flags
proposed patch	none

Laszlo Gombos

Reported 2010-08-17 12:39:09 PDT

Q_WS_S60 is not going to be defined for Symbian^4 devices as Q_WS_S60 used to guard Avkon UI framework dependencies (see http://doc.qt.nokia.com/4.7-snapshot/qtglobal.html#Q_WS_S60). Going trough all the usage of Q_WS_S60 in WebKit I have found that all of them really should have been Q_OS_SYMBIAN. Patch will follow.

Attachments
proposed patch (5.84 KB, patch) 2010-08-17 12:49 PDT, Laszlo Gombos	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Laszlo Gombos

Comment 1 2010-08-17 12:49:21 PDT

Created attachment 64622 [details] proposed patch

Ariya Hidayat

Comment 2 2010-08-17 17:03:41 PDT

Comment on attachment 64622 [details] proposed patch re=me

WebKit Commit Bot

Comment 3 2010-08-17 18:22:34 PDT

Comment on attachment 64622 [details] proposed patch Clearing flags on attachment: 64622 Committed r65581: <http://trac.webkit.org/changeset/65581>

WebKit Commit Bot

Comment 4 2010-08-17 18:22:39 PDT

All reviewed patches have been landed. Closing bug.

Simon Hausmann

Comment 5 2010-08-24 06:02:24 PDT

Revision r65581 cherry-picked into qtwebkit-2.1 with commit cb830f8e78d51660cf665b1feed2c90ac942210e

Note You need to log in before you can comment on or make changes to this bug.