Bug 44124

Summary: [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, hausmann
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Description Flags
proposed patch none

Description Laszlo Gombos 2010-08-17 12:39:09 PDT
Q_WS_S60 is not going to be defined for Symbian^4 devices as Q_WS_S60 used to guard Avkon UI framework dependencies (see http://doc.qt.nokia.com/4.7-snapshot/qtglobal.html#Q_WS_S60). Going trough all the usage of Q_WS_S60 in WebKit I have found that all of them really should have been Q_OS_SYMBIAN.

Patch will follow.
Comment 1 Laszlo Gombos 2010-08-17 12:49:21 PDT
Created attachment 64622 [details]
proposed patch
Comment 2 Ariya Hidayat 2010-08-17 17:03:41 PDT
Comment on attachment 64622 [details]
proposed patch

Comment 3 WebKit Commit Bot 2010-08-17 18:22:34 PDT
Comment on attachment 64622 [details]
proposed patch

Clearing flags on attachment: 64622

Committed r65581: <http://trac.webkit.org/changeset/65581>
Comment 4 WebKit Commit Bot 2010-08-17 18:22:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-08-24 06:02:24 PDT
Revision r65581 cherry-picked into qtwebkit-2.1 with commit cb830f8e78d51660cf665b1feed2c90ac942210e