Bug 44119

Summary: Update json results generator so incremental json includes results for tests failed in previous runs
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch ojan: review+

Victor Wang
Reported 2010-08-17 11:01:36 PDT
JSON results generator generates incremental json file and uploads it to test results server to merge with the aggregated results. The current version of incremental json only contains results for tests failed in current run. It does not have results for tests that pass in this run but failed before. This is incorrect as the server needs to know the results for those tests (pass, skipped, no data etc). To fix this, json results generator needs to get list of tests from test results server aggregated json and add current run results for these tests to incremental json.
Attachments
Proposed Patch (10.08 KB, patch)
2010-08-17 14:32 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
Proposed Patch (10.48 KB, patch)
2010-08-17 15:29 PDT, Victor Wang 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-08-17 14:32:11 PDT
Created attachment 64632 [details] Proposed Patch
WebKit Review Bot
Comment 2 2010-08-17 14:32:53 PDT
Attachment 64632 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:86: trailing whitespace [pep8/W291] [5] WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:291: trailing whitespace [pep8/W291] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Victor Wang
Comment 3 2010-08-17 15:29:41 PDT
Created attachment 64647 [details] Proposed Patch
Ojan Vafai
Comment 4 2010-08-17 16:49:43 PDT
Comment on attachment 64647 [details] Proposed Patch WebKitTools/ChangeLog:6 + results for tests pass in current run but failed before. Nit: results for tests that pass...
Victor Wang
Comment 5 2010-08-17 16:58:32 PDT
Committed r65574: <http://trac.webkit.org/changeset/65574>
Note You need to log in before you can comment on or make changes to this bug.