Bug 44117 – Add support for getting test name list json from test results server

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Victor Wang]

This is for incremental json update to test results server.

In order to correctly merge the incremental json with the aggregated json in test results server, the incremental json needs to contain results not only for the tests failed in current runs, but also for tests failed in previous runs. To avoid upload full test results, we need to add api to test results server to download json that only contains list of test names. No need to include non-test-list data and details of test results.

[Victor Wang]

Created attachment 64630 [details]
Proposed Patch

[Ojan Vafai]

Comment on attachment 64630 [details]
Proposed Patch

WebKitTools/ChangeLog:5
 +          Add support to test results server for downloading json that
Nit: Add support to the test results server...

WebKitTools/ChangeLog:9
 +          results so it includes results not only for tests failed in
Nit: results so that it includes...for tests that failed in...

WebKitTools/TestResultServer/model/jsonresults.py:437
 +              Json file with test name list only. The json format is the same
Nit: s/Json/JSON or s/Json/json

WebKitTools/TestResultServer/model/jsonresults.py:454
 +              "tests": dict.fromkeys(tests, {"results": [], "times": []})}
This is a lot of bloat just for the tests list. Can "tests" just be tests.keys()? Does this need to be in the same format as the one stored in the datastore?

[Victor Wang]

Created attachment 64640 [details]
Updated per comments

[Victor Wang]

(In reply to comment #2)
> (From update of attachment 64630 [details])
> WebKitTools/ChangeLog:5
>  +          Add support to test results server for downloading json that
> Nit: Add support to the test results server...
done

> 
> WebKitTools/ChangeLog:9
>  +          results so it includes results not only for tests failed in
> Nit: results so that it includes...for tests that failed in...
done

> 
> WebKitTools/TestResultServer/model/jsonresults.py:437
>  +              Json file with test name list only. The json format is the same
> Nit: s/Json/JSON or s/Json/json
done

> 
> WebKitTools/TestResultServer/model/jsonresults.py:454
>  +              "tests": dict.fromkeys(tests, {"results": [], "times": []})}
> This is a lot of bloat just for the tests list. Can "tests" just be tests.keys()? Does this need to be in the same format as the one stored in the datastore?

not required by datastore format. I was doing this to avoid modifying the json results generator so we can share the existing logic for generating results.json. No need to have "results' and "times" if I refactor the json results generator little bit, so removed them from the update patch.

[Victor Wang]

Comment on attachment 64640 [details]
Updated per comments

Clearing flags on attachment: 64640

Committed r65567: <http://trac.webkit.org/changeset/65567>

[Victor Wang]

All reviewed patches have been landed.  Closing bug.