Bug 44112

Summary: Web Inspector: activate/deactivate breakpoints using v8 debugger flag
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch. none

Description Pavel Podivilov 2010-08-17 08:56:02 PDT 
Web Inspector: activate/deactivate breakpoints using v8 debugger flag
Comment 1 Pavel Podivilov 2010-08-17 08:58:01 PDT 
Created attachment 64597 [details]
Proposed patch.
Comment 2 Yury Semikhatsky 2010-08-17 22:42:07 PDT 
Comment on attachment 64597 [details]
Proposed patch.

WebKit/chromium/src/js/DebuggerScript.js:200
 +      Debug.debuggerFlags().breakPointsActive.setValue(args.enabled);
Breakpoints are always activated in the frontend when it's just launched. With this code we may deactivate breakpoints, then close frontend, reopen frontend and get an inconsistent state of the flag in the debugger script and frontend. Please fix this.
Comment 3 WebKit Commit Bot 2010-08-19 08:45:08 PDT 
Comment on attachment 64597 [details]
Proposed patch.

Clearing flags on attachment: 64597

Committed r65674: <http://trac.webkit.org/changeset/65674>
Comment 4 WebKit Commit Bot 2010-08-19 08:45:13 PDT 
All reviewed patches have been landed.  Closing bug.