Bug 44112

Summary: Web Inspector: activate/deactivate breakpoints using v8 debugger flag
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch. none

Pavel Podivilov
Reported 2010-08-17 08:56:02 PDT
Web Inspector: activate/deactivate breakpoints using v8 debugger flag
Attachments
Proposed patch. (2.05 KB, patch)
2010-08-17 08:58 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2010-08-17 08:58:01 PDT
Created attachment 64597 [details] Proposed patch.
Yury Semikhatsky
Comment 2 2010-08-17 22:42:07 PDT
Comment on attachment 64597 [details] Proposed patch. WebKit/chromium/src/js/DebuggerScript.js:200 + Debug.debuggerFlags().breakPointsActive.setValue(args.enabled); Breakpoints are always activated in the frontend when it's just launched. With this code we may deactivate breakpoints, then close frontend, reopen frontend and get an inconsistent state of the flag in the debugger script and frontend. Please fix this.
WebKit Commit Bot
Comment 3 2010-08-19 08:45:08 PDT
Comment on attachment 64597 [details] Proposed patch. Clearing flags on attachment: 64597 Committed r65674: <http://trac.webkit.org/changeset/65674>
WebKit Commit Bot
Comment 4 2010-08-19 08:45:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.