Bug 44111

Summary: feTurbulence filter doesn't display properly
Product: WebKit Reporter: Renata Hodovan <rhodovan.u-szeged>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, krit, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Fix displaying problems of feTurbulence and add a new test.
krit: review-
Fix displaying problems of feTurbulence and add a new test. none

Description Renata Hodovan 2010-08-17 08:39:29 PDT
feTurbulence filter doesn't display properly
Comment 1 Dirk Schulze 2010-08-17 08:52:20 PDT
hm? :-P Can you provide some more details? :-)
Comment 2 Renata Hodovan 2010-08-17 09:06:30 PDT
Created attachment 64598 [details]
Fix displaying problems of feTurbulence and add a new test.
Comment 3 Renata Hodovan 2010-08-17 09:12:24 PDT
(In reply to comment #1)
> hm? :-P Can you provide some more details? :-)

We already talked about that by http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/filters-turb-02-f.html the two pics are not equivalent in WebKit. I've found the reason of this. It's fixed now and this test is added to WebKit as well.
Comment 4 Dirk Schulze 2010-08-17 09:29:07 PDT
Comment on attachment 64598 [details]
Fix displaying problems of feTurbulence and add a new test.

Patch looks good. But discribe the bug and how you fixed it in the ChangeLog, please.

I'll give r+ on a better ChangeLog.
Comment 5 Dirk Schulze 2010-08-17 10:41:09 PDT
(In reply to comment #3)
> (In reply to comment #1)
> > hm? :-P Can you provide some more details? :-)
> 
> We already talked about that by http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/filters-turb-02-f.html the two pics are not equivalent in WebKit. I've found the reason of this. It's fixed now and this test is added to WebKit as well.

Yes I know, but you should explain it in bug reports as well.
Comment 6 Renata Hodovan 2010-08-17 12:22:15 PDT
Created attachment 64616 [details]
Fix displaying problems of feTurbulence and add a new test.
Comment 7 Dirk Schulze 2010-08-17 22:25:18 PDT
Comment on attachment 64616 [details]
Fix displaying problems of feTurbulence and add a new test.

Great Patch! r=me
Comment 8 Dirk Schulze 2010-08-18 06:08:11 PDT
Comment on attachment 64616 [details]
Fix displaying problems of feTurbulence and add a new test.

Sorry, forgot to set cq+.
Comment 9 Zoltan Herczeg 2010-08-18 06:11:36 PDT
Landed in http://trac.webkit.org/changeset/65590
Forgot to close the bug.