Bug 44097

Summary:

Web Inspector: get rid of node and scoped object-specific ids.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	yurys: review+
[PATCH] Patch to land.	none

Pavel Feldman

Reported 2010-08-17 03:08:14 PDT

Patch to follow.

Attachments
[PATCH] Proposed change. (23.31 KB, patch) 2010-08-17 03:10 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
[PATCH] Patch to land. (23.30 KB, patch) 2010-08-17 06:15 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-08-17 03:10:52 PDT

Created attachment 64569 [details] [PATCH] Proposed change.

Yury Semikhatsky

Comment 2 2010-08-17 06:07:44 PDT

Comment on attachment 64569 [details] [PATCH] Proposed change. WebCore/inspector/front-end/InjectedScript.js:411 + var className = this._className(obj); Simply return this._className(obj) WebCore/inspector/front-end/InjectedScriptAccess.js:41 + console.error("Access to injected script with no id"); These two lines can be substituted with one console.assert which also supports stack traces.

Pavel Feldman

Comment 3 2010-08-17 06:15:45 PDT

Created attachment 64580 [details] [PATCH] Patch to land.

Pavel Feldman

Comment 4 2010-08-17 06:31:09 PDT

Comment on attachment 64580 [details] [PATCH] Patch to land. Clearing flags on attachment: 64580 Committed r65499: <http://trac.webkit.org/changeset/65499>

Pavel Feldman

Comment 5 2010-08-17 06:31:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.