Bug 44077

Summary:

[chromium] Prepare to rename WebFileSystem interface to WebFileUtilities

Product:

WebKit

Reporter:

Kinuko Yasuda <kinuko>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ericu, eric, fishd, jianli, kkanetkar, michaeln, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	jianli: review+

Kinuko Yasuda

Reported 2010-08-16 15:14:52 PDT

Now that we're going to implement HTML5 FileSystem API, it'd be natural to have WebFileSystem as a WebKit API for HTML5 FileSystem and to rename current WebFileSystem (that implements platform/FileSystem methods) to something like WebFileUtilities.

Attachments
Patch (13.95 KB, patch) 2010-08-16 15:40 PDT, Kinuko Yasuda	no flags	Details Formatted Diff Diff
Patch (14.12 KB, patch) 2010-08-16 16:27 PDT, Kinuko Yasuda	jianli: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kinuko Yasuda

Comment 1 2010-08-16 15:40:14 PDT

Created attachment 64528 [details] Patch

Jian Li

Comment 2 2010-08-16 15:55:27 PDT

Comment on attachment 64528 [details] Patch Please add "[chromium]" prefix to the bug title and ChangeLog description. Please also mention why we need to rename WebFileSystem to WebFileUtilities (probably same thing as you put in the bug detail).

Kinuko Yasuda

Comment 3 2010-08-16 16:24:27 PDT

(In reply to comment #2) > (From update of attachment 64528 [details]) > Please add "[chromium]" prefix to the bug title and ChangeLog description. Please also mention why we need to rename WebFileSystem to WebFileUtilities (probably same thing as you put in the bug detail). Sorry for lack of description/discussion, there was a discussion about how the new API for the HTML5 FileSystem should be named/defined (you can see some of the discussion at https://bugs.webkit.org/show_bug.cgi?id=43151). Basically why this patch tries to rename WebFileSystem to WebFileUtilities is that we thought it would be less confusing (for external API users - which happen to be chromium only) to make "WebFileSystem" a corresponding API of HTML5 FileSystem. (Internally WebFileSystem implements platform/FileSystem so renaming it to another has some side effect too.) How do you think?

Kinuko Yasuda

Comment 4 2010-08-16 16:27:31 PDT

Created attachment 64535 [details] Patch

Jian Li

Comment 5 2010-08-16 17:34:11 PDT

Comment on attachment 64535 [details] Patch Looks good except minor issues. Please fix them before you land the patch. WebKit/chromium/public/WebFileSystem.h:38 + // FIXME: Clean up this class once the renaming to WebFileUtilities has done. has done => is done Please also change all other occurrences.

Kinuko Yasuda

Comment 6 2010-08-16 20:53:59 PDT

Committed r65482: <http://trac.webkit.org/changeset/65482>

WebKit Review Bot

Comment 7 2010-08-16 21:08:53 PDT

http://trac.webkit.org/changeset/65482 might have broken Chromium Win Release

Kinuko Yasuda

Comment 8 2010-08-16 21:37:30 PDT

(In reply to comment #7) > http://trac.webkit.org/changeset/65482 might have broken Chromium Win Release This has been fixed in http://trac.webkit.org/changeset/65485.

Note You need to log in before you can comment on or make changes to this bug.