| Summary: | [Cairo] Remove unnecessary full-surface copies from ImageCairo and GraphicsContextCairo | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, antognolli+webkit, eric, hyatt, krit, webkit.review.bot | ||||
| Priority: | P3 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Martin Robinson
2010-08-16 15:07:32 PDT
Created attachment 64527 [details]
Patch for this issue
Attachment 64527 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/cairo/GRefPtrCairo.h:25: cairo_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/graphics/cairo/GRefPtrCairo.h:26: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
These style issues are false positives from new forward declarations. Comment on attachment 64527 [details]
Patch for this issue
r=me
Comment on attachment 64527 [details] Patch for this issue Clearing flags on attachment: 64527 Committed r65530: <http://trac.webkit.org/changeset/65530> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/65530 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65529 http://trac.webkit.org/changeset/65530 |