Bug 44076

Summary: [Cairo] Remove unnecessary full-surface copies from ImageCairo and GraphicsContextCairo
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antognolli+webkit, eric, hyatt, krit, webkit.review.bot
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue none

Martin Robinson
Reported 2010-08-16 15:07:32 PDT
r65451 exposed a couple unnecessary full-surface copies in the Cairo code. This patch tracks removing them.
Attachments
Patch for this issue (8.44 KB, patch)
2010-08-16 15:24 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-08-16 15:24:32 PDT
Created attachment 64527 [details] Patch for this issue
WebKit Review Bot
Comment 2 2010-08-16 15:26:08 PDT
Attachment 64527 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/cairo/GRefPtrCairo.h:25: cairo_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/platform/graphics/cairo/GRefPtrCairo.h:26: cairo_surface_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2010-08-16 15:30:00 PDT
These style issues are false positives from new forward declarations.
Dave Hyatt
Comment 4 2010-08-16 18:07:06 PDT
Comment on attachment 64527 [details] Patch for this issue r=me
Martin Robinson
Comment 5 2010-08-17 12:05:09 PDT
Comment on attachment 64527 [details] Patch for this issue Clearing flags on attachment: 64527 Committed r65530: <http://trac.webkit.org/changeset/65530>
Martin Robinson
Comment 6 2010-08-17 12:05:15 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-08-17 12:46:08 PDT
http://trac.webkit.org/changeset/65530 might have broken GTK Linux 64-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65529 http://trac.webkit.org/changeset/65530
Note You need to log in before you can comment on or make changes to this bug.