Bug 44061

Summary: [Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, hausmann
Priority: P2 Keywords: HTML5, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch v2
none
Proposed patch v3 none

Description Andreas Kling 2010-08-16 09:28:28 PDT
The current implementation calls QPainterPath::closePath() indiscriminately which leads to rendering artifacts.

See for example:
http://www.kevs3d.co.uk/dev/canvask3d/k3d_test.html
Comment 1 Andreas Kling 2010-08-16 09:34:37 PDT
Created attachment 64500 [details]
Proposed patch
Comment 2 Ariya Hidayat 2010-08-16 14:16:38 PDT
Comment on attachment 64500 [details]
Proposed patch

Per our discussion on IRC, let's try another approach first.

Clearing the review flag.
Comment 3 Andreas Kling 2010-08-16 16:22:47 PDT
Created attachment 64534 [details]
Proposed patch v2
Comment 4 Andreas Kling 2010-08-16 17:26:21 PDT
Created attachment 64537 [details]
Proposed patch v3

As per discussion on IRC, track last subpath via a new (Qt-only) int member in Path.
Comment 5 Ariya Hidayat 2010-08-16 17:34:30 PDT
Comment on attachment 64537 [details]
Proposed patch v3

LGTM. re=me
Comment 6 Andreas Kling 2010-08-16 17:41:23 PDT
Comment on attachment 64537 [details]
Proposed patch v3

Clearing flags on attachment: 64537

Committed r65472: <http://trac.webkit.org/changeset/65472>
Comment 7 Andreas Kling 2010-08-16 17:41:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Simon Hausmann 2010-08-24 03:06:15 PDT
Revision r65472 cherry-picked into qtwebkit-2.1 with commit c2aaec160209c180b6bf0ef9c14e706adf841498