Bug 44054

Summary:

Chromium DevTools: Support runtime property name/value pairs instead of feature names as navigation state.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, loislo, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed fix.	yurys: review+

Pavel Feldman

Reported 2010-08-16 06:36:29 PDT

Patch to follow.

Attachments
[PATCH] Proposed fix. (6.28 KB, patch) 2010-08-16 06:38 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-08-16 06:38:39 PDT

Created attachment 64490 [details] [PATCH] Proposed fix.

Yury Semikhatsky

Comment 2 2010-08-16 06:52:28 PDT

Comment on attachment 64490 [details] [PATCH] Proposed fix. WebKit/chromium/public/WebDevToolsAgentClient.h:54 + virtual void runtimeFeatureStateChanged(const WebString& feature, bool enabled) { } let's remove this one

Pavel Feldman

Comment 3 2010-08-18 02:38:10 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h M WebKit/chromium/public/WebDevToolsAgentClient.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h Committed r65594

WebKit Review Bot

Comment 4 2010-08-18 03:27:59 PDT

http://trac.webkit.org/changeset/65594 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597

Note You need to log in before you can comment on or make changes to this bug.