|Severity:||Normal||CC:||abarth, ap, commit-queue, eric, hohle, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.6|
Description johanneslindenbaum 2010-08-14 22:52:18 PDT
Comment 1 Adam Barth 2010-08-17 21:29:48 PDT
In all likelihood this is fixed on trunk. Testing now.
Comment 2 Adam Barth 2010-08-17 21:36:48 PDT
*** Bug 28195 has been marked as a duplicate of this bug. ***
Comment 3 Adam Barth 2010-08-17 21:38:18 PDT
Created attachment 64668 [details] Patch
Comment 4 Alexey Proskuryakov 2010-08-19 14:30:55 PDT
Comment on attachment 64668 [details] Patch Thanks! It's a little surprising to see noscript without script, and maybe we should be also testing the more common case where they come together, but I don't think there is a strong technical reason to. I'm a little confused by your comment in bug 28195 - is 13522 the same, after all?
Comment 5 Adam Barth 2010-08-19 14:36:30 PDT
> Thanks! It's a little surprising to see noscript without script, and maybe we should be also testing the more common case where they come together, but I don't think there is a strong technical reason to. Huh? I don't understand this comment. Why would script and noscript come together? > I'm a little confused by your comment in bug 28195 - is 13522 the same, after all? I haven't looked at Bug 13522 yet. Bug 28195 is the same bug as this one. The old parser didn't understand how to properly lex <noscript>. The new parser lexs it as RAWTEXT and then makes it not display.
Comment 6 Alexey Proskuryakov 2010-08-19 15:12:26 PDT
> Huh? I don't understand this comment. Why would script and noscript come together? They usually did on Web pages (and sample code) where I saw <noscript>, with it logically being fallback for scripted behavior. Of course, they are not technically related, which is why I said there was no strong reason to test that case.
Comment 7 WebKit Commit Bot 2010-08-19 15:35:52 PDT
Comment on attachment 64668 [details] Patch Clearing flags on attachment: 64668 Committed r65712: <http://trac.webkit.org/changeset/65712>
Comment 8 WebKit Commit Bot 2010-08-19 15:35:58 PDT
All reviewed patches have been landed. Closing bug.
Comment 9 WebKit Review Bot 2010-08-19 16:44:58 PDT
http://trac.webkit.org/changeset/65712 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65699 http://trac.webkit.org/changeset/65700 http://trac.webkit.org/changeset/65701 http://trac.webkit.org/changeset/65702 http://trac.webkit.org/changeset/65703 http://trac.webkit.org/changeset/65704 http://trac.webkit.org/changeset/65705 http://trac.webkit.org/changeset/65706 http://trac.webkit.org/changeset/65707 http://trac.webkit.org/changeset/65708 http://trac.webkit.org/changeset/65709 http://trac.webkit.org/changeset/65710 http://trac.webkit.org/changeset/65711 http://trac.webkit.org/changeset/65712 http://trac.webkit.org/changeset/65713