Bug 44016 – Add ability to post arbitrary input events from the InjectedBundle (for EventSender)

• Component: WebKit2
• Status: RESOLVED WONTFIX

[Sam Weinig]

Add ability to post arbitrary input events from the InjectedBundle (for EventSender).

[Sam Weinig]

Created attachment 64431 [details]
patch

[WebKit Review Bot]

Attachment 64431 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleMouseEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundleMouseEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleWheelEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundleKeyboardEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/InjectedBundleWheelEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:63:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:64:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:65:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:75:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:76:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:77:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleKeyboardEvent.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 12 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

I was working on a similar approach when I became unsure if it made sense. It seems that WebCore really needs an NSEvent for input methods - or we need a much deeper refactoring for them to work.

I'm not sure if adding injected bundle interfaces is helpful at this point.

[Alexey Proskuryakov]

One thing I'd like to preserve in eventSender is an ability to create native events (such as NSEvent), to test how they are handled. Testing only WebCore seems particularly insufficient in this case.

[Sam Weinig]

(In reply to comment #4)
> One thing I'd like to preserve in eventSender is an ability to create native events (such as NSEvent), to test how they are handled. Testing only WebCore seems particularly insufficient in this case.

My plan was to add a function for each platform that takes a platform specific event (NSEvent on mac) and creates a WKBundleFooEvent from it, this way we could test the conversion (and we wouldn't have to do the manual conversion ourselves in the test runner.

[Adam Barth]

What's the status of this patch?  It's been in the review queue for a while.

[Sam Weinig]

(In reply to comment #6)
> What's the status of this patch?  It's been in the review queue for a while.

Apparently not a lot of love :(.  I am taking it out of the queue for now, and will come back to when I am more focused on EventSender again.