Bug 44012 – [Qt] DumpRenderTree runs only one test from command mode

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mahesh Kulkarni]

Layout testing for qtwebkit is executed by run-webkit-script

One can also run .\DumpRenderTree with one test case as command mode arguments. But DumpRenderTree does not support passing more than one test case as arguments which is very handy in debugging test cases where DumpRenderTree passes when run individually but not in a group. (In case of geolocation layout testing running cases together gives different result)

This bug is to allow DumpRenderTreeQt to allow passing of multiple test cases to execute.

[Mahesh Kulkarni]

Created attachment 64422 [details]
patch

This patch implements supporting multiple test case as command line arguments. This fix could be extended to support folder (and nested folders) argument as well which will read all html files and run them one by one. 

Running DumpRenderTree from command mode with multiple cases helps to debug the failing cases which passes if run individually.  

Please review

[Mahesh Kulkarni]

Created attachment 65405 [details]
patch

From previous patch, 

1) Changed customMode to StandAloneMode as per Kenneth suggestion. 
2) Added support for folder path (non-recursive) support to DRT. Any folder containing test files can be run directly with DRT. 
Ex: ./WebKitBuild/Debug/bin/DumpRenderTree ~/webkit/LayoutTests/fast/dom/Geolocation/ 
(will run all *.html files in sequence which helped in debugging DRT alone with qtcreator)

[Andreas Kling]

Removing this from QtWebKit 2.1 blockers as it's clearly not release-critical.

[Kenneth Rohde Christiansen]

Comment on attachment 65405 [details]
patch

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:619
 +          QStringList onlyHtmls("*.html");
what about .xhtml etc?

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:621
 +          for (int i = 0; i < m_standAloneModeTestList.size(); ++i)
unsigned?

[Kenneth Rohde Christiansen]

Comment on attachment 65405 [details]
patch

r- due to only accepting .html tests

[Mahesh Kulkarni]

Created attachment 65537 [details]
patch

incorporate changes as per comment #4

[Kenneth Rohde Christiansen]

Comment on attachment 65537 [details]
patch

Comments start with capital and ends with dot.

[Andras Becsi]

Committed revision 66092.

[Andras Becsi]

Comment on attachment 65537 [details]
patch

Clearing flags.

[Mahesh Kulkarni]

Thank you Kenneth and Andras!