Bug 43994

Summary: [GTK] GTK+ drawing idle starved
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: WebKitGTKAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://themaninblue.com/experiment/AnimationBenchmark/canvas/
Attachments:
Description Flags
proposed fix kenneth: review+

Gustavo Noronha (kov)
Reported 2010-08-13 15:50:23 PDT
The page at http://themaninblue.com/experiment/AnimationBenchmark/canvas/ is able to starve the idle that is responsible for redrawing in GTK+. We need to further fine tune the priorities we use in our various timeouts.
Attachments
proposed fix (1.49 KB, patch)
2010-08-13 15:59 PDT, Gustavo Noronha (kov) 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2010-08-13 15:59:24 PDT
Created attachment 64383 [details] proposed fix This fixes the issue with that site for me, even with the browser under great stress, such as playing flash videos, some chromeexperiments, the "video blow up" demo, and playing http://trailers.apple.com/movies/paramount/ironman2/ironman2-34rgrwt9-tlr2_720p.mov. The priority used is the one GTK+ uses for its redraw idle.
Martin Robinson
Comment 2 2010-08-14 17:43:04 PDT
Wow! That was a fast fix. Maybe you should change the priority to GDK_PRIORITY_REDRAW? http://library.gnome.org/devel/gdk/stable/gdk-Events.html#GDK-PRIORITY-REDRAW:CAPS
Gustavo Noronha (kov)
Comment 3 2010-08-16 06:12:39 PDT
I could, but then I'd need to add the gdk include to this file, do you think it's worth it? =)
Martin Robinson
Comment 4 2010-08-16 08:12:54 PDT
Hrm. My preference is either the GDK include or a comment explaining where the "+ 20" comes from.
Gustavo Noronha (kov)
Comment 5 2010-08-16 10:12:01 PDT
I landed this as r65438 adding the include. Thanks for the reviews!
WebKit Review Bot
Comment 6 2010-08-16 10:52:59 PDT
http://trac.webkit.org/changeset/65438 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.