Bug 43986 – [REGRESSION] Web Inspector: crash on closing window with open inspector

• Component: Web Inspector (Deprecated)
• Status: RESOLVED DUPLICATE

[Rowan Beentje]

Created attachment 64362 [details]
Sample crash report

I'm currently on r65222; for the last few days, WebKit has been crashing for me if I close a window with an open inspector.  I can reproduce this easily.

Steps to reproduce:
1) Open WebKit
2) Go to http://webkit.org/
3) Open the web inspector (I use the keyboard shortcut, it opens on the Resources pane by default)
4) Enable resources (I don't have the always-on option enabled)
5) Close the window

I then get a crash, like the following:


Application Specific Information:
objc_msgSend() selector name: _isClosed

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib               	0x00007fff80c4d120 objc_msgSend + 44
1   com.apple.WebKit              	0x0000000100a3ddb4 -[WebInspectorWindowController close] + 84
2   com.apple.WebKit              	0x0000000100a3d86f -[WebInspectorWindowController destroyInspectorView] + 159
3   com.apple.WebCore             	0x00000001010793ab WebCore::InspectorFrontendHost::closeWindow() + 27
4   com.apple.WebCore             	0x000000010122f206 WebCore::jsInspectorFrontendHostPrototypeFunctionCloseWindow(JSC::ExecState*) + 118
5   ???                           	0x000039209b6001aa 0 + 62812208497066
6   com.apple.JavaScriptCore      	0x00000001007d8f54 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, JSC::JSValue*) + 900

[Rowan Beentje]

This still occurs as of r65398.

Enabling resources appears to be the trigger - without that, this bug doesn't get triggered on window close.

[Rowan Beentje]

This still occurs as of r65727:


Application Specific Information:
objc_msgSend() selector name: _isClosed

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libobjc.A.dylib               	0x00007fff87bf511c objc_msgSend + 40
1   com.apple.WebKit              	0x0000000100a3d364 -[WebInspectorWindowController close] + 84
2   com.apple.WebKit              	0x0000000100a3d89f -[WebInspectorWindowController destroyInspectorView] + 159
3   com.apple.WebCore             	0x000000010106eb5b WebCore::InspectorFrontendHost::closeWindow() + 27
4   com.apple.WebCore             	0x0000000101227ca6 WebCore::jsInspectorFrontendHostPrototypeFunctionCloseWindow(JSC::ExecState*) + 118
5   ???                           	0x00005551358001aa 0 + 93807278293418
6   com.apple.JavaScriptCore      	0x00000001007d9c74 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, JSC::JSValue*) + 900


Having experimented with the Resources view being "always on", I can still reproduce the crash, so haven't been able to find a workaround yet :/

[Rowan Beentje]

Aha - workaround found - if I click on the "check" button at the bottom of the inspector panel to disable resource tracking before I close the window, the crash doesn't occur.

So definitely the resources view at fault!

[Jessie Berlin]

(In reply to comment #3)
> Aha - workaround found - if I click on the "check" button at the bottom of the inspector panel to disable resource tracking before I close the window, the crash doesn't occur.
> 
> So definitely the resources view at fault!

Are you sure that it doesn't crash when you disabled resource tracking? This sounds very much like https://bugs.webkit.org/show_bug.cgi?id=44230 and a similar crash on Windows, and even on Mac it still crashes for me when I disable resource tracking and then close the main window.

Marking as a duplicate of 44230.

*** This bug has been marked as a duplicate of bug 44230 ***

[Rowan Beentje]

After further testing yesterday, disabling the resources panel *sometimes* prevents the crash - as you say, it's not a full workaround.

It does look like this is a duplicate of #44230 - apologies, I must have missed that one.

[Rowan Beentje]

Ah, never mind, just noticed the IDs, that gets me off the hook ;)