Summary: | A flaw in detecting mobile WebKit in WebKitSite/misc/WebKitDetect.js | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Qiu <robin.qiu> | ||||||
Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | charles.wei, commit-queue, levin, mrowe, staikos, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://webkit.org/misc/WebKitDetect.html | ||||||||
Attachments: |
|
Description
Robin Qiu
2010-08-13 11:11:11 PDT
Created attachment 64368 [details]
Patch v1
Comment on attachment 64368 [details]
Patch v1
What character do they have after Mobile? It seems like this might match MobileOpera or something silly like that.
(In reply to comment #2) > (From update of attachment 64368 [details]) > What character do they have after Mobile? It seems like this might match MobileOpera or something silly like that. It's a space, so, should we use " Mobile\b" as pattern? Before landing, please add a bug link to your ChangeLog. Comment on attachment 64368 [details]
Patch v1
r-, due to missing bug link in changelog, plus didn't you want to add the \b to make sure that you match "Mobile/" and "Mobile "?
Created attachment 66048 [details]
patch v2
Change " Mobile/" to " Mobile\\b".
Add bugzilla link.
Comment on attachment 66048 [details]
patch v2
ok
(In reply to comment #7) > (From update of attachment 66048 [details]) > ok Thanks for your review. :) Comment on attachment 66048 [details] patch v2 Clearing flags on attachment: 66048 Committed r66819: <http://trac.webkit.org/changeset/66819> All reviewed patches have been landed. Closing bug. |