Summary: | Build Configuration Support for MathML in Chromimum | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Milowski <alex> | ||||||
Component: | MathML | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, peter | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Comment on attachment 64220 [details]
Patch to add MathML to build
WebKit/chromium/features.gypi:62
+ 'ENABLE_MATHML=1',
Let's get in the rest minus this part now, and start the discussion about doing this. Sound good?
Created attachment 64232 [details]
Updated patch with ENABLE_MATHML=0 in features
(In reply to comment #1) > (From update of attachment 64220 [details]) > WebKit/chromium/features.gypi:62 > + 'ENABLE_MATHML=1', > Let's get in the rest minus this part now, and start the discussion about doing this. Sound good? I just set ENABLE_MATHML to '0' so that people know that the flag is there to turn on. Comment on attachment 64232 [details] Updated patch with ENABLE_MATHML=0 in features Rejecting patch 64232 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20832 test cases. transitions/transition-end-event-transform.html -> failed Exiting early after 1 failures. 19785 tests run. 771.14s total testing time 19784 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 275 test cases (1%) had stderr output Full output: http://queues.webkit.org/results/3710122 I don't think this failure has anything to do with this patch. Can we try again? Comment on attachment 64220 [details] Patch to add MathML to build Cleared Jeremy Orlow's review+ from obsolete attachment 64220 [details] so that this bug does not appear in http://webkit.org/pending-commit. (In reply to comment #4) > (From update of attachment 64232 [details]) > Rejecting patch 64232 from commit-queue. > > Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 > Running build-dumprendertree > Compiling Java tests > make: Nothing to be done for `default'. > Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests > Testing 20832 test cases. > transitions/transition-end-event-transform.html -> failed > > Exiting early after 1 failures. 19785 tests run. > 771.14s total testing time > > 19784 test cases (99%) succeeded > 1 test case (<1%) had incorrect layout > 275 test cases (1%) had stderr output > > Full output: http://queues.webkit.org/results/3710122 This output doesn't tell me anything. Since these tests aren't using the changes to the Chromium build, I highly doubt they are related. Comment on attachment 64232 [details]
Updated patch with ENABLE_MATHML=0 in features
Flaky test.
Comment on attachment 64232 [details] Updated patch with ENABLE_MATHML=0 in features Clearing flags on attachment: 64232 Committed r65441: <http://trac.webkit.org/changeset/65441> All reviewed patches have been landed. Closing bug. |
Created attachment 64220 [details] Patch to add MathML to build This patch adds support for turning on MathML in the chromium build.