Bug 43904

Summary: [Qt] QGWV: Canvas never updates after first frame when using GL viewport
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Layout and RenderingAssignee: QtWebKit Unassigned <webkit-qt-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: ariya.hidayat, benjamin, kling
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.mrspeaker.net/dev/parcycle/
Attachments:
Description Flags
Proposed patch kling: review-

Benjamin Poulain
Reported 2010-08-12 03:27:38 PDT
When a QGraphicsWebView is used in a GraphicsView with a QGLWidget as the viewport, the view is never updated for canvas updates. To reproduce: -start QtTestBrowser on http://www.mrspeaker.net/dev/parcycle/ -change the mode to GraphicsView -enable the GL widget as a viewport -enjoy
Attachments
Proposed patch (2.13 KB, patch)
2010-08-20 19:47 PDT, Andreas Kling 		kling: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-08-20 19:47:03 PDT
Created attachment 65016 [details] Proposed patch
Benjamin Poulain
Comment 2 2010-08-20 19:54:29 PDT
What about other asynchronous APIs like openVG and X11?
Andreas Kling
Comment 3 2010-08-20 20:29:41 PDT
Comment on attachment 65016 [details] Proposed patch r-ing myself, this is a bit more hairy than I first realized..
Andreas Kling
Comment 4 2010-08-21 04:08:13 PDT
This has been fixed in Qt with commit f46cb7033fc3bfc17c4ccf9125d670810322a0f5 in oslo-staging-1. The problem was that the GL texture for the QPixmap backing store of the ImageBuffer was never synced after the first time since the QPainter::begin() call is what marks it dirty (detach_no is incremented which alters the cacheKey().)
Note You need to log in before you can comment on or make changes to this bug.