Bug 43873

Summary: regression in generateMipmap
Product: WebKit Reporter: Nick <computerfreak97>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, kbr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Bug Depends on: 33805    
Bug Blocks:    
Attachments:
Description Flags
patch dglazkov: review+, zmo: commit-queue-

Description Nick 2010-08-11 13:27:39 PDT
There are no textures in the demo at: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/demos/mozilla/spore/index.html. It is confirmed that there are by looking at in in chrome/firefox.
Comment 1 Zhenyao Mo 2010-08-12 11:01:20 PDT
It should be a recent regression.  My build from this Monday still shows the texture.
Comment 2 Zhenyao Mo 2010-08-12 13:26:27 PDT
I am looking into this.
Comment 3 Zhenyao Mo 2010-08-12 13:31:43 PDT
Ok, it's a bug in the NPOT/Texture completeness patch, so it is before this Monday's build.  I was fixing it on Monday; that's why my Monday's build shows the texture correctly.  Only I got distracted with other bugs, so I haven't committed the fix.

Will upload a patch shortly after.
Comment 4 Zhenyao Mo 2010-08-12 14:03:14 PDT
After generateMipmap() on a POT texture, it should draw successfully with the texture.
Comment 5 Zhenyao Mo 2010-08-12 14:08:59 PDT
Created attachment 64258 [details]
patch

test is in sync with khronos conformance test, except one failing case.  Commented out that failing case for now.
Comment 6 Kenneth Russell 2010-08-12 15:39:31 PDT
Comment on attachment 64258 [details]
patch

Looks good to me.
Comment 7 Dimitri Glazkov (Google) 2010-08-12 15:51:51 PDT
Comment on attachment 64258 [details]
patch

ok.
Comment 8 Zhenyao Mo 2010-08-12 15:59:47 PDT
Committed r65277: <http://trac.webkit.org/changeset/65277>