Bug 43861

Summary: Fix issues in test results server related to times data type and test item insertion
Product: WebKit Reporter: Victor Wang <victorw>
Component: Tools / TestsAssignee: Victor Wang <victorw>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch
ojan: review+
Update per comments none

Victor Wang
Reported 2010-08-11 10:36:45 PDT
Two issues in json results merging in test results server: 1. times should be int not string. 2. when inserting a new test item, if there is an older item (but not the most recent one) whose value is same as the new one to insert, the old one should NOT be removed. This is what the json_results_generator.py does. The current test results server removes the old one, which is wrong. Not sure where I got the impression that the old data with dupe type should be remove, need to fix it.
Attachments
Proposed Patch (10.70 KB, patch)
2010-08-11 10:46 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
Proposed Patch (16.24 KB, patch)
2010-08-11 15:40 PDT, Victor Wang 		ojan: review+
DetailsFormatted DiffDiff
Update per comments (16.29 KB, patch)
2010-08-17 11:30 PDT, Victor Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Victor Wang
Comment 1 2010-08-11 10:46:04 PDT
Created attachment 64134 [details] Proposed Patch
Victor Wang
Comment 2 2010-08-11 10:58:40 PDT
Comment on attachment 64134 [details] Proposed Patch The test results and times also need to be normalized after merging: prune tests where all runs pass, truncate all test items to max number of builds etc.
Victor Wang
Comment 3 2010-08-11 15:40:46 PDT
Created attachment 64170 [details] Proposed Patch
Ojan Vafai
Comment 4 2010-08-17 11:17:28 PDT
Comment on attachment 64170 [details] Proposed Patch WebKitTools/TestResultServer/model/jsonresults.py:47 + JSON_RESULTS_MAX_BUILDS = 750 FYI, we changed this number to 1500. See http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py#L63. WebKitTools/TestResultServer/model/jsonresults.py:282 + (is_all_pass and max_time <= JSON_RESULTS_MIN_TIME)): I think this should be a strick less-than.
Victor Wang
Comment 5 2010-08-17 11:30:19 PDT
Created attachment 64611 [details] Update per comments
Victor Wang
Comment 6 2010-08-17 11:30:54 PDT
(In reply to comment #4) > (From update of attachment 64170 [details]) > WebKitTools/TestResultServer/model/jsonresults.py:47 > + JSON_RESULTS_MAX_BUILDS = 750 > FYI, we changed this number to 1500. See http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py#L63. done > > WebKitTools/TestResultServer/model/jsonresults.py:282 > + (is_all_pass and max_time <= JSON_RESULTS_MIN_TIME)): > I think this should be a strick less-than. done
Victor Wang
Comment 7 2010-08-17 11:49:10 PDT
Committed r65527: <http://trac.webkit.org/changeset/65527>
Ojan Vafai
Comment 8 2010-08-27 18:38:03 PDT
Comment on attachment 64611 [details] Update per comments Removing the review flag since this is committed.
Note You need to log in before you can comment on or make changes to this bug.