Bug 43850

Summary:

[gdb] Need to update webcore.py, which is out of sync for recent changes of basic string classes

Product:

WebKit

Reporter:

Hayato Ito <hayato>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agl, commit-queue, eric, evan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
merge-pretty-printers	none

Description Hayato Ito 2010-08-11 07:02:53 PDT

Basic string classes, such as AtomicString, has moved to WTF from WebCore.

We need to update WebKitTools/gdb/webcore.py, which defines pretty printers for that classes.

Comment 1 Hayato Ito 2010-08-11 07:11:20 PDT

Created attachment 64109 [details]
merge-pretty-printers

Comment 2 Hayato Ito 2010-08-11 07:18:35 PDT

I think it's good timing to merge webcore.py and wtf.py.
I've merged them and name it 'webkit.py'.

I left 'webcore.py' for backward compatibility because that file is already used by developers.
I'll update WIKI (http://trac.webkit.org/wiki/GDB) once this patch is landed.

Comment 3 Eric Seidel (no email) 2010-08-12 07:20:38 PDT

CCing people who might have a clue about this code...

Comment 4 Adam Langley 2010-08-12 07:44:58 PDT

I'm only passingly familiar with gdb scripts, but this all looks reasonable.

Comment 5 WebKit Commit Bot 2010-08-12 10:32:54 PDT

Comment on attachment 64109 [details]
merge-pretty-printers

Clearing flags on attachment: 64109

Committed r65254: <http://trac.webkit.org/changeset/65254>

Comment 6 WebKit Commit Bot 2010-08-12 10:32:59 PDT

All reviewed patches have been landed.  Closing bug.