Bug 4385

Summary:

DrawTest test viewer doesn't work with WebCore tests

Product:

WebKit

Reporter:

Tobias Lidskog <tobiaslidskog>

Component:

SVG

Assignee:

Tobias Lidskog <tobiaslidskog>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Update imagePathForSVGPath:	eric: review+

Description Tobias Lidskog 2005-08-11 04:19:47 PDT

The test viewer in DrawTest is supposed to show the rendered svg next to a reference png image. 
Currently it doesn't handle the directory layout in WebCore where the reference images are stored next to 
the svg files.

Comment 1 Eric Seidel (no email) 2005-08-11 04:25:26 PDT

I agree.  And tobias says he already has a fix, passing bug to him...

Comment 2 Tobias Lidskog 2005-08-11 04:29:28 PDT

Created attachment 3339 [details]
Update imagePathForSVGPath:

Update to handle case where png files are in the same directory as the svg
files + minor code cleanup. More code rearranging could be done later.

Comment 3 Tobias Lidskog 2005-08-11 04:41:26 PDT

Comment on attachment 3339 [details]
Update imagePathForSVGPath:

Setting review flag

Comment 4 Eric Seidel (no email) 2005-08-11 04:44:57 PDT

Comment on attachment 3339 [details]
Update imagePathForSVGPath:

Looks fine to me.