Bug 43831

Summary: [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch v1
none
(committed with r65159, r=ariya)patch v2 none

Antonio Gomes
Reported 2010-08-10 23:02:27 PDT
As is, we are creating the QStateMachine and all associated objects (QState, QPropertyAnimations and QAbstractTransition) for the YRotation action (Developer->GraphicsView->YRotation) at WebViewGraphicsBased constructor time. It is unnecessery. Patch moves all this stuff to the slot that is activated by the associated menuitem to this action, lazily initiating it.
Attachments
patch v1 (4.25 KB, patch)
2010-08-10 23:06 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
(committed with r65159, r=ariya)patch v2 (5.20 KB, patch)
2010-08-11 06:18 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-08-10 23:06:26 PDT
Created attachment 64076 [details] patch v1
Antonio Gomes
Comment 2 2010-08-11 06:18:03 PDT
Created attachment 64103 [details] (committed with r65159, r=ariya)patch v2 Diff from v1: 1) Moved QStateMachine to a class member of WebView (named m_machine) instead of being it a static variable in WebView::animatedYFlip slot. 2) Removed the yFlipRequest signal, now that it is unneeded.
Ariya Hidayat
Comment 3 2010-08-11 06:27:27 PDT
Comment on attachment 64103 [details] (committed with r65159, r=ariya)patch v2 LGTM (if you fix the last remaining static).
Antonio Gomes
Comment 4 2010-08-11 09:01:49 PDT
Comment on attachment 64103 [details] (committed with r65159, r=ariya)patch v2 Clearing flags on attachment: 64103 Committed r65159: <http://trac.webkit.org/changeset/65159>
Note You need to log in before you can comment on or make changes to this bug.