Bug 43823

Summary:

[chromium/mac]: Fix colors in compositing mode

Product:

WebKit

Reporter:

Nico Weber <thakis>

Component:

New Bugs

Assignee:

Nico Weber <thakis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, jamesr, kbr, vangelis

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Nico Weber 2010-08-10 18:24:14 PDT

[chromium/mac]: Fix colors in compositing mode

Comment 1 Nico Weber 2010-08-10 18:24:41 PDT

Created attachment 64063 [details]
Patch

Comment 2 Nico Weber 2010-08-10 18:28:41 PDT

Created attachment 64064 [details]
Patch

Comment 3 Nico Weber 2010-08-10 18:30:45 PDT

With this, the compositor draws exactly as the software path on my machine.

Comment 4 James Robinson 2010-08-10 18:32:23 PDT

That looks completely reasonable.  Dimitri, wanna give this a loving touch?

Comment 5 Kenneth Russell 2010-08-10 18:34:28 PDT

Comment on attachment 64064 [details]
Patch

Looks good to me. Thanks for tracking this down!

Comment 6 WebKit Commit Bot 2010-08-10 20:26:20 PDT

Comment on attachment 64064 [details]
Patch

Rejecting patch 64064 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 64064, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
cgi?id=64064&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=43823&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 64064 from bug 43823.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Comment 7 James Robinson 2010-08-10 20:27:48 PDT

Yeah Nico - if you set commit-queue+ before r+ is set the commit queue will try to land it, see no reviewer, and then throw a hissy fit.  Wait for the r+ before setting cq+ again.

Comment 8 Nico Weber 2010-08-10 20:37:05 PDT

Will do. Sorry.

Comment 9 WebKit Commit Bot 2010-08-11 16:15:09 PDT

Comment on attachment 64064 [details]
Patch

Clearing flags on attachment: 64064

Committed r65194: <http://trac.webkit.org/changeset/65194>

Comment 10 WebKit Commit Bot 2010-08-11 16:15:14 PDT

All reviewed patches have been landed.  Closing bug.