Bug 43775

Summary: REGRESSION(r64988): "It seems to break chromium's ui_tests" (Requested by hamaji on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, hamaji, jhawkins
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 43648    
Attachments:
Description Flags
ROLLOUT of r64988 none

Description WebKit Review Bot 2010-08-10 01:27:40 PDT
http://trac.webkit.org/changeset/64988 broke the build:
"It seems to break chromium's ui_tests" (Requested by hamaji on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-10 01:27:51 PDT
Created attachment 63987 [details]
ROLLOUT of r64988

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Shinichiro Hamaji 2010-08-10 02:05:40 PDT
Committed r65060: <http://trac.webkit.org/changeset/65060>
Comment 3 WebKit Commit Bot 2010-08-10 02:14:36 PDT
Comment on attachment 63987 [details]
ROLLOUT of r64988

Rejecting patch 63987 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Parsed 3 diffs from patch file(s).
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/public/WebFrameClient.h
Hunk #1 FAILED at 90.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebFrameClient.h.rej
patching file WebKit/chromium/src/FrameLoaderClientImpl.cpp
Hunk #1 FAILED at 246.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/FrameLoaderClientImpl.cpp.rej

Full output: http://queues.webkit.org/results/3755011
Comment 4 Shinichiro Hamaji 2010-08-10 02:24:54 PDT
Comment on attachment 63987 [details]
ROLLOUT of r64988

Oops, I landed this manually but forgot to clear cq+