Summary: | [GTK] Inputs of type 'search' have weird looking checkboxes instead of search/clear icons | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mrobinson | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2010-08-09 17:08:14 PDT
Created attachment 63958 [details]
proposed patch
Comment on attachment 63958 [details]
proposed patch
Good.
I think it might be good to make these icons members of the RenderTheme, much like the images used for media buttons. What do you think? Oops, sorry Martin, I just landed r65074 before reading your comment. I thought about doing it that way, but I didn't really see advantages to adding the complexity, do you see any advantage in having member variables? Comment on attachment 63958 [details] proposed patch Landed as r65074. I'm leaving the bug open while we explore Martin's suggestion. The reason I suggested was in case we could track changes to the icon theme. Perhaps we cannot, but either way this could easily be a followup patch. I'll close this issue for now! :) |