| Summary: | Fix compilation of VideoLayerChromium on Mac OS X with compositor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> | ||||
| Component: | Platform | Assignee: | Kenneth Russell <kbr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ajwong, dglazkov, eric, hclam, japhet, levin, scherkus, vangelis, vrk, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Kenneth Russell
2010-08-09 16:33:58 PDT
Created attachment 63952 [details]
Patch
Thanks to Vangelis for initial patch.
Thanks for fixing this! Attachment 63952 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:128: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 63952 [details]
Patch
Please fix the tab issue before landing. (I doubt that svn will let you commit it with a tab anyway.)
(In reply to comment #4) > (From update of attachment 63952 [details]) > Please fix the tab issue before landing. (I doubt that svn will let you commit it with a tab anyway.) Will do. Committed r65018: <http://trac.webkit.org/changeset/65018> http://trac.webkit.org/changeset/65018 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65017 http://trac.webkit.org/changeset/65018 |