| Summary: | Fix regression in Mac Chromium UI for audio/video controls | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Victoria Kirst <vrk> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hclam, levin | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Victoria Kirst
2010-08-09 15:11:51 PDT
Created attachment 63951 [details]
Patch
The function change in this patch looks good to me. It'll break chromium layout tests, but it's ok because those are the correct results. Please ping jianli@ as he's the webkit sheriff on duty. Created attachment 63953 [details]
Patch
(In reply to comment #2) > The function change in this patch looks good to me. > > It'll break chromium layout tests, but it's ok because those are the correct results. > > Please ping jianli@ as he's the webkit sheriff on duty. This isn't a great answer. WK gardeners have plenty to do without more being added. You have two much better answers: Method 1: Provide a new baseline as part of this patch. Method 2: * Mark the tests as failing the tests in this patch. * When you are able (to pull the baseline from the canaries), get the new baseline * Verify it. * Submit a new patch with the new baselines and unmark the tests as failing. (In reply to comment #4) > (In reply to comment #2) > > The function change in this patch looks good to me. > > > > It'll break chromium layout tests, but it's ok because those are the correct results. > > > > Please ping jianli@ as he's the webkit sheriff on duty. > > This isn't a great answer. WK gardeners have plenty to do without more being added. > > You have two much better answers: > Method 1: Provide a new baseline as part of this patch. > Method 2: > * Mark the tests as failing the tests in this patch. > * When you are able (to pull the baseline from the canaries), get the new baseline > * Verify it. > * Submit a new patch with the new baselines and unmark the tests as failing. Sorry, I meant to reply to Victoria. I forgot we can use test_expactations.txt to expect failure, thanks for reminding me! Comment on attachment 63953 [details]
Patch
r- based on dave's comment? This needs text_expectations.txt changes I guess?
Created attachment 64176 [details]
Patch
Comment on attachment 64176 [details]
Patch
Added expected failures to test_expectations.txt, so this passes all media layout tests.
Comment on attachment 64176 [details] Patch Clearing flags on attachment: 64176 Committed r65215: <http://trac.webkit.org/changeset/65215> All reviewed patches have been landed. Closing bug. |