Bug 43749

Summary: Eliminate extra traversal of the tree when determining ability to lazy-attach a Node.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, eric, hyatt, mjs, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+, eric: commit-queue-

Dimitri Glazkov (Google)
Reported 2010-08-09 15:10:13 PDT
Eliminate extra traversal of the tree when determining ability to lazy-attach a Node.
Attachments
Patch (1.61 KB, patch)
2010-08-09 15:12 PDT, Dimitri Glazkov (Google) 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-08-09 15:12:32 PDT
Created attachment 63933 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-08-09 15:16:50 PDT
Since neither SVG nor Input shadow DOM aren't using this path (they use home-baked attachement), the check for whether we're inside of the shadow tree isn't needed. This gives a small, but consistent win in Dromaeo's DOM Modification. If you're really mean, you can make me write layout tests to prove that this check isn't meaningful inside of the shadow DOM.
Dimitri Glazkov (Google)
Comment 3 2010-08-17 09:03:26 PDT
Adding more peeps.
Eric Seidel (no email)
Comment 4 2010-08-17 09:06:01 PDT
Comment on attachment 63933 [details] Patch Lipstick on a pig. Eager attach needs to die. Can you explain better why this check is not needed in your ChangeLog?
Eric Seidel (no email)
Comment 5 2010-08-17 09:07:23 PDT
Sorry, meant to CC adele, not beth. Adele is the queen of the world of shadow DOMs, iirc.
Dimitri Glazkov (Google)
Comment 6 2010-08-17 09:08:01 PDT
(In reply to comment #4) > (From update of attachment 63933 [details]) > Lipstick on a pig. Eager attach needs to die. > > Can you explain better why this check is not needed in your ChangeLog? Will do.
Dimitri Glazkov (Google)
Comment 7 2010-08-17 09:15:27 PDT
Committed r65508: <http://trac.webkit.org/changeset/65508>
Dimitri Glazkov (Google)
Comment 8 2010-08-17 10:58:53 PDT
I bungled landing this and had to land the actual change in http://trac.webkit.org/changeset/65517. Sorry :-\
Note You need to log in before you can comment on or make changes to this bug.