Bug 43715

Summary:

REGRESSION(r64967): "New files weren't added to all build files ==> lots of broken builds" (Requested by dumi on #webkit).

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dumi, eric, kenneth, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

42472

Attachments:

Description	Flags
ROLLOUT of r64967	none
Platform build patches for Qt, Gtk, and Windows	dumi: review-, dumi: commit-queue-

Description WebKit Review Bot 2010-08-09 03:53:49 PDT

http://trac.webkit.org/changeset/64967 broke the build:
"New files weren't added to all build files ==> lots of broken builds" (Requested by dumi on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

Comment 1 WebKit Review Bot 2010-08-09 03:54:05 PDT

Created attachment 63882 [details]
ROLLOUT of r64967

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Ryuan Choi 2010-08-09 04:02:54 PDT

*** Bug 43708 has been marked as a duplicate of this bug. ***

Comment 3 Dumitru Daniliuc 2010-08-09 04:12:19 PDT

Looks like it might be easier (and faster...) to patch WebCore.vcproj/WebCore.vcproj and the gtk 64-bit build file. I'll take care of that.

Comment 4 Ryuan Choi 2010-08-09 04:43:29 PDT

(In reply to comment #3)
> Looks like it might be easier (and faster...) to patch WebCore.vcproj/WebCore.vcproj and the gtk 64-bit build file. I'll take care of that.

hmm. do I need to reopen Bug 43708 ?

Comment 5 Alex Milowski 2010-08-09 04:48:51 PDT

Created attachment 63886 [details]
Platform build patches for Qt, Gtk, and Windows

Comment 6 Dumitru Daniliuc 2010-08-09 04:59:45 PDT

Comment on attachment 63886 [details]
Platform build patches for Qt, Gtk, and Windows

Alex is not a committer, and we can't wait for the commit-queue to pick up this patch, so I submitted it (+ changes to CMakeLists.txt) unreviewed in r64976. Changing the flags to r-, cq-.

Comment 7 Antonio Gomes 2010-08-09 05:01:48 PDT

(In reply to comment #6)
> (From update of attachment 63886 [details])
> Alex is not a committer, and we can't wait for the commit-queue to pick up this patch, so I submitted it (+ changes to CMakeLists.txt) unreviewed in r64976. Changing the flags to r-, cq-.

no problem. thank you.

Comment 8 Csaba Osztrogonác 2010-12-06 09:30:17 PST

Comment on attachment 63882 [details]
ROLLOUT of r64967

remove cq? from obsolete patch