Bug 43711

Summary: Web Inspector: eliminate showPanel from InspectorFrontend and panels' enum from InspectorController
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version. yurys: review+

Ilya Tikhonovsky
Reported 2010-08-09 02:19:09 PDT
%subj%
Attachments
[patch] initial version. (20.89 KB, patch)
2010-08-09 02:30 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-08-09 02:30:22 PDT
Created attachment 63876 [details] [patch] initial version.
Yury Semikhatsky
Comment 2 2010-08-09 02:40:32 PDT
Comment on attachment 63876 [details] [patch] initial version. WebCore/inspector/InspectorController.cpp:  + if (panelName == "storage" || panelName == "databases") Please make sure that Storage panel will still be restored after your change.
Ilya Tikhonovsky
Comment 3 2010-08-09 04:45:37 PDT
Committed r64973 M WebCore/WebCore.exp.in M WebCore/ChangeLog M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/InspectorController.cpp M WebCore/inspector/Inspector.idl M WebCore/inspector/InspectorFrontend.h M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/ExtensionServer.js M WebCore/inspector/InspectorController.h M LayoutTests/inspector/debugger-no-nested-pause.html M LayoutTests/inspector/debugger-proto-property.html M LayoutTests/inspector/elements-panel-limited-children.html M LayoutTests/inspector/debugger-pause-in-eval-script.html M LayoutTests/inspector/debugger-pause-on-debugger-statement.html M LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html M LayoutTests/inspector/debugger-eval-while-paused.html M LayoutTests/inspector/debugger-cyclic-ref.html M LayoutTests/ChangeLog r64973 = acb548e8bc8abaa405557882efc6483576321376 (refs/remotes/trunk)
Note You need to log in before you can comment on or make changes to this bug.